-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Docker caching #29
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @maxslarsson and the rest of your teammates on Graphite |
c19ecb5
to
deb282e
Compare
8ca6fb8
to
bcf397a
Compare
deb282e
to
aa6c245
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix merge conflicts please
bcf397a
to
3f3e486
Compare
3f3e486
to
a06fe03
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we able to just rerun the workflow to see a speed increase from caching?
@ZachGarcia42 reviewed this PR from Slack with Graphite
Yea we can, but I don't think it'll have a massive speed increase unfortunately because of how Docker works. Basically it treats each line in the Dockerfile as a layer, so whenever the inputs for one line changes, it has to rebuild every line below. So whenever we change any code, it invalidates the Do you know if there is a Bazel command to download and build the dependencies only? |
I don't think that's too feasible unfortunately. 13 minutes isn't terrible. If that's slower than we want, we can create a second docker file for the workflow and move back to uploading/downloading an artifact from the bazel tests. I think this is cleaner than copying some of the repo, doing a build step, copying the rest, and then building the actual target |
Yea for sure, I think 13 minutes is fast enough for our purposes, at least for now. If not, we can go back in history and get your artifact solution again. I think most of the time we test the code locally, and the Docker build is just to get onto the RPi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this improvement!
Fixes #31